Bug #2745

RCP: 0.8.0, Dialog boxes of Sub-corpus and Partition creation are broken when CQP corpus is not ready

Added by Sebastien Jacquot 9 months ago. Updated 9 months ago.

Status:Feedback Start date:01/24/2020
Priority:Normal Due date:
Assignee:- % Done:

80%

Category:UI Spent time: -
Target version:TXM 0.8.1

Description

Dialog boxes of Sub-corpus and Partition creation are broken when CQP corpus is not ready.
Where trying to get some parent corpus properties to fill the widgets, CQP exceptions are raised when we can't create sub-corpus or partition.

Solution 1

  • use the same solution as in the TXMEditor to manage the parents branch computation
    => Use the new modal dialog box class /org.txm.rcp/src/main/java/org/txm/rcp/swt/dialog/AdvancedProgressMonitorDialog.java to ensure the parents are computed and to block the UI during the process

Solution 2

  • move all sub-corpus and partition creation code to some TXMEditor to benefit of the already managed parents branch computation.

Validation tests

WIP SJ:
  • purpose here is to test on large corpora that contains not computed partitions or corpus that the commands to create a partition and sub-corpus when called on a sub-corpus hierarchy works as expected

Related issues

related to Bug #2742: RCP: 0.8.0, TXMEditor parameter toolbar is broken when CQ... Feedback 01/24/2020
related to Feature #2756: RCP: 0.8.0, Convert Dialog boxes of Sub-corpus and Partit... Feedback 01/24/2020

Associated revisions

Revision 2567
Added by Sebastien Jacquot 9 months ago

Fixes: Dialog boxes of Sub-corpus and Partition creation are broken when CQP corpus is not ready (refs #2745)
Progresses on: Editor results computing executed with not computed parents branch or too long process may lead to display wrong data in editor (refs #2682)

History

#1 Updated by Sebastien Jacquot 9 months ago

  • Description updated (diff)
  • Status changed from New to Feedback
  • % Done changed from 0 to 80

Solution 1 has been implemented. Need new issue and wiki specs for solution 2.

#2 Updated by Sebastien Jacquot 9 months ago

New issue for solution 2: #2756.

Also available in: Atom PDF